Re: [ 29/68] kprobes: return proper error code from register_kprobe()

From: Jonathan Nieder
Date: Mon Mar 12 2012 - 00:58:08 EST


Hi,

Greg KH wrote:

> 3.0-stable review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> From: Prashanth Nageshappa <prashanth@xxxxxxxxxxxxxxxxxx>
>
> commit f986a499ef6f317d906e6f6f281be966e1237a10 upstream.

Looks good for 3.2.y.

This is a pointless no-op in 3.0.y, since it doesn't include commit
bc81d48d13d8 (kprobes: Return -ENOENT if probe point doesn't exist,
2011-06-29).

[...]
> This patch fixes it by returning -EINVAL upon failure.
[...]
> @@ -1396,7 +1398,7 @@ out:
>
> return ret;
>
> -fail_with_jump_label:
> +cannot_probe:
> preempt_enable();
> jump_label_unlock();
> return -EINVAL;

Hope that helps,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/