Re: [PATCH 5/7] drivers/atm/eni.c: ensure arguments to request_irqand free_irq are compatible

From: David Miller
Date: Sun Mar 11 2012 - 18:46:34 EST


From: Julia Lawall <julia.lawall@xxxxxxx>
Date: Sun, 11 Mar 2012 22:16:25 +0100 (CET)

> From: Julia Lawall <Julia.Lawall@xxxxxxx>
>
> Convert calls to free_irq so that the second argument is the same as
> the
> last argument of the corresponding call to request_irq. Without this
> property, free_irq does nothing.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>

Applied, but this driver also has a larger problem, it doesn't
free the IRQ (nor do any other kind of chip shutdown and cleanups)
when the driver is unloaded. The unload function is just one empty
function with a comment.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/