[PATCH 5/7] drivers/atm/eni.c: ensure arguments to request_irq and free_irq are compatible

From: Julia Lawall
Date: Sun Mar 11 2012 - 15:37:28 EST


From: Julia Lawall <Julia.Lawall@xxxxxxx>

Convert call to request_irq so that the last argument is the same as the
second argument of the subsequent call to free_irq. Without this
property, free_irq does nothing.

I have chosen to keep the call to free_irq as is, because its second
argument is more like its first argument.

Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>

---
Not tested. I don't know if I have made the right choice.

drivers/atm/eni.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c
index 956e9ac..89e7223 100644
--- a/drivers/atm/eni.c
+++ b/drivers/atm/eni.c
@@ -1800,7 +1800,8 @@ static int __devinit eni_start(struct atm_dev *dev)

DPRINTK(">eni_start\n");
eni_dev = ENI_DEV(dev);
- if (request_irq(eni_dev->irq,&eni_int,IRQF_SHARED,DEV_LABEL,dev)) {
+ if (request_irq(eni_dev->irq, &eni_int, IRQF_SHARED, DEV_LABEL,
+ eni_dev)) {
printk(KERN_ERR DEV_LABEL "(itf %d): IRQ%d is already in use\n",
dev->number,eni_dev->irq);
error = -EAGAIN;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/