Re: [PATCH -v2] mm: SLAB Out-of-memory diagnostics

From: Pekka Enberg
Date: Fri Mar 09 2012 - 14:41:19 EST


On Wed, Mar 7, 2012 at 4:46 PM, Rafael Aquini <aquini@xxxxxxxxxx> wrote:
>> > Nitpick:
>> >
>> > What about "node: 0" instead of "node0: " ?
>> >
>>
>> Good catch, that format would match the output of the slub out-of-memory
>> messages.
>>
>
> To be honest, I really don't see a big advantage on the nitpick, however, if we
> want to accurately copycat the slub output here, I can insert a blank space
> between the word and the digit, like the following:
>   "node #: ..."

So if you're interested in getting this patch to v3.4, now would be a
good time to update the patch as per review comments and resend.

Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/