Re: [RFC] c/r: prctl: Add ability to set new mm_struct::exe_file v3

[Oleg Nesterov]

On 03/09, Cyrill Gorcunov wrote:
>
> OK, Oleg, can't argue, you've convinced me ;) I'll drop this WARN_ON.

Yes, yes, I am a troll!

> Would it be enough for your Reviewed-by tag? /me hides

Yes.

But, when you send the patch to Andrew, please remind that he
should remove the evidence of my ignorance from -mm first.


Just one note for the record, prctl_set_mm_exe_file() does

	if (mm->num_exe_file_vmas)
		return -EBUSY;

We could do

	if (mm->exe_file)
		return -EBUSY;

This way "because this feature is a special to C/R" becomes
really true. IOW, you can't do PR_SET_MM_EXE_FILE twice.

I am fine either way, just I want to ensure you really want
the current version.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/