Re: [PATCH 1/2] boot: ignore early NMIs

From: Fernando Luis VÃzquez Cao
Date: Fri Mar 09 2012 - 04:31:20 EST


On 03/09/2012 01:35 AM, Eric W. Biederman wrote:

I am fine with your approach. I suggest a big fat comment mentioning
the 10 byte requirement and the register requirement.

Neither one is locally obvious which makes it easy to goof when
modifying the code.
Done.



Doing something less brittle than:
extern const char early_idt_handlers[NUM_EXCEPTION_VECTORS][10];
in segment.h might be a good idea as well.
Tackled that one too.

I will be replying to this email with the updated patches.

Thanks,
Fernando

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/