Re: [PATCH] staging:iio:tsl2563 rewrite probe error handling

From: Dan Carpenter
Date: Fri Mar 09 2012 - 01:21:45 EST


On Thu, Mar 08, 2012 at 07:51:07PM -0800, Grant Grundler wrote:
> Hi Jonathan!
>
> On Wed, Mar 7, 2012 at 3:28 AM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> > Fundamentally an excellent patch fixing some real issues,
>
> Thank you! :)
>
> > but just
> > because I'm in that sort of mood I'll be fussy about the fact it is
> > one patch.
> >
> > To nitpick, I'd have prefered this to be two patches. First that fixes
> > the issues and the second that adds the additional output.  Actually
> > should probably have even had a third making the white space changes.
>
> Yup - I see/understand why. I need to improve my git foo and work
> habits so it's not hard to play with a series of smaller patches
> rather than one patch that does everything to one function.
>

If you use git citool then you can just highlight and right click on
the lines you want to merge.

regards,
dan carpenter

Attachment: signature.asc
Description: Digital signature