Re: [PATCH] dvb-core: fix DVBFE_ALGO_HW retune bug

From: Christian KÃnig
Date: Thu Mar 08 2012 - 17:55:19 EST


Simon Arlott <simon <at> fire.lp0.eu> writes:

>
> Commit 7e07222 breaks DVBFE_ALGO_HW tuning after a retune is requested,
> which causes bad tuning on my TBS 6920.
>
> [ 0.769091] pci 0000:06:00.0: [14f1:8852] type 0 class 0x000400
> [ 19.733530] CORE cx23885[0]: subsystem: 6920:8888, board: TurboSight TBS
6920 [card=14,autodetected]
> [ 762.824912] cx24116_load_firmware: FW version 1.23.86.1
>
> 7e0722215a510921cbb73ab4c37477d4dcb91bf8 [media] dvb-core: Don't pass DVBv3
parameters on tune() fops
>
> Although re_tune is set to true when FESTATE_RETUNE occurs, it is never
> set back to false which the old code used to do when !FESTATE_RETUNE.
>
> This patch sets re_tune to false if !(state & FESTATE_RETUNE).
>
[snip]
>
> Signed-off-by: Simon Arlott <simon <at> fire.lp0.eu>

Please make sure that this patch is pushed upstream, since the patch who
introduced the bug is already in 3.3-rc6 but not this fix. Otherwise:

Tested by: Christian KÃnig <deathsimple@xxxxxxxxxxx




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/