Re: [PATCH] net/hyperv: Advertise hv_netvsc instead of netvsc asdriver name

From: Greg KH
Date: Thu Mar 08 2012 - 10:52:25 EST


On Thu, Mar 08, 2012 at 07:16:16AM +0100, Olaf Hering wrote:
> On Wed, Mar 07, Greg KH wrote:
>
> > On Wed, Mar 07, 2012 at 09:17:46PM +0100, Olaf Hering wrote:
> > > On Wed, Mar 07, Haiyang Zhang wrote:
> > >
> > >
> > > > @@ -482,7 +484,7 @@ MODULE_DEVICE_TABLE(vmbus, id_table);
> > > >
> > > > /* The one and only one */
> > > > static struct hv_driver netvsc_drv = {
> > > > - .name = "netvsc",
> > > > + .name = MODULE_NAME,
> > >
> > > It would be nice if this could be applied to 3.3.
> > > hv_storvsc and hid-hyperv already use the same naming, this patch was
> > > send last year already but was not applied for some reason.
> >
> > What userspace tools depend on this that requires it to be in 3.3?
>
> It represents the module names, at least for pci and other bus types.

Yes, but no one should care what the name of the module is.

> hwinfo uses it to recognize a network interface (storage in case of
> hv_storvsc).

That tool should report the real module name, not rely on the name to
match based on the structure, if you really care about the real module
name.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/