Re: [PATCH] dlm, sctp: Do not allocate a fd for peeloff

From: David Miller
Date: Thu Mar 08 2012 - 03:25:09 EST


From: Vladislav Yasevich <vladislav.yasevich@xxxxxx>
Date: Wed, 07 Mar 2012 11:29:20 -0500

> On 03/07/2012 10:41 AM, Benjamin Poirier wrote:
>> avoids allocating a fd that a) propagates to every kernel thread and
>> usermodehelper b) is not properly released.
>>
>> References: http://article.gmane.org/gmane.linux.network.drbd/22529
>> Signed-off-by: Benjamin Poirier <bpoirier@xxxxxxx>
>
> It might make sense to change sctp_do_peeloff to take the association id as
> the first argument and not do the mapping from id to association yourself.
> It's a bit ugly to expose internal sctp structures outside of SCTP.

Agreed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/