Re: [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag

[Roland McGrath]

A few of the vDSO VM_ALWAYSDUMP cases have a comment about the core dump.
(It looks like they were all copied from my original comment in
arch/x86/vdso/vdso32-setup.c.)  So those should be removed where they are.
(You removed some of them, but not all.)  You should put that comment into
always_dump_vma.

get_gate_vma is always defined quite trivially, and is also the most
logically obvious case, so I would test it first.

It sounds like the Tile special case is unnecessary, so just
arch_vma_name(vma) != NULL is an adequate test.  Please give it
a clear comment about why that test makes sense, i.e. because all
extant uses are for a vDSO or something similar.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/