Re: [PATCH 4/5] HID: autoload hid-multitouch as needed

From: Jiri Kosina
Date: Wed Mar 07 2012 - 16:36:45 EST


On Tue, 6 Mar 2012, benjamin.tissoires wrote:

> From: Benjamin Tissoires <benjamin.tissoires@xxxxxxx>
>
> The code is inspired from the one present in the bttv module.
>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxx>
> ---
>
> As I mentioned in the mail 0/5, I'd really like to have your opinion on this
> one. I copied the code from bttv, but it forces us to change hid_device which
> is not very good for ABI changes reasons.

Haven't closely inspected the patch yet, I will comment on it later. But
generally, I wouldn't be worried about changing hid_device per se ... it's
not really an ABI, it's not exported to userspace.

It's internal kernel-ABI, yes. But we are free to change that in any way
we wish.

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/