RE: [PATCH] net/hyperv: Advertise hv_netvsc instead of netvsc asdriver name

From: Haiyang Zhang
Date: Wed Mar 07 2012 - 14:58:10 EST




> -----Original Message-----
> From: Greg KH [mailto:greg@xxxxxxxxx]
> Sent: Wednesday, March 07, 2012 2:22 PM
> To: Haiyang Zhang
> Cc: KY Srinivasan; davem@xxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; Olaf Hering
> Subject: Re: [PATCH] net/hyperv: Advertise hv_netvsc instead of netvsc as
> driver name
>
> On Wed, Mar 07, 2012 at 11:05:31AM -0800, Haiyang Zhang wrote:
> > From: Olaf Hering <olaf@xxxxxxxxx>
> >
> > Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> > Signed-off-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> > ---
> > drivers/net/hyperv/netvsc_drv.c | 6 ++++--
> > 1 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/hyperv/netvsc_drv.c
> b/drivers/net/hyperv/netvsc_drv.c
> > index 0ae7a1a..53d1ee5 100644
> > --- a/drivers/net/hyperv/netvsc_drv.c
> > +++ b/drivers/net/hyperv/netvsc_drv.c
> > @@ -40,6 +40,8 @@
> >
> > #include "hyperv_net.h"
> >
> > +#define MODULE_NAME "hv_netvsc"
>
> No, please use the built-in macro for this and don't define your own,
> that's totally redundant.

I have submitted a patch using the built-in KBUILD_MODNAME.
Thanks,
- Haiyang

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/