Re: [PATCH] [SCSI] sd: set BIO_MAPPED_INTEGRITY bit correctly insd_dif_prepare().

From: Matthew Wilcox
Date: Wed Mar 07 2012 - 10:44:37 EST


On Wed, Mar 07, 2012 at 08:11:35PM +0530, santosh nayak wrote:
> - bio->bi_flags |= BIO_MAPPED_INTEGRITY;
> + set_bit(BIO_MAPPED_INTEGRITY, &bio->bi_flags);

This uses an atomic operation; you should rather use __set_bit instead.

--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/