Re: [PATCH 9/9] drm/i915/intel_i2c: reuse GMBUS2 value from polling loop

From: Chris Wilson
Date: Wed Mar 07 2012 - 07:09:50 EST


On Wed, 7 Mar 2012 19:50:50 +0800, Daniel Kurtz <djkurtz@xxxxxxxxxxxx> wrote:
> Save the GMBUS2 value read while polling for state changes, and then
> reuse this value when determining for which reason the loops were exited.
> This is a small optimization which saves a couple of bus accesses for
> memory mapped IO registers.
>
> Note: checkpatch doesn't like this ('assigning in if condition'), but it seems
> like the cleanest implementation.
>
> Signed-off-by: Daniel Kurtz <djkurtz@xxxxxxxxxxxx>
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris

--
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/