RE: [PATCH v5 2/2] mmc: core: Support packed command for eMMC4.5 device

From: Seungwon Jeon
Date: Tue Mar 06 2012 - 19:17:25 EST


Maya Erez <merez@xxxxxxxxxxxxxx> wrote:
> > Hi. Merez.
> >
> > Thanks a lot about your performance measurement.
> >
> > I think that your measurement is enough and correct and the firmware
> > of mmc vender should be optimized or change properly rather than
> > modifying the current patch.
> >
> > And currently we can use only write packed cmd by my suggestion.
> >
> > I would like to add my reviewd-by tag in updated patches also.
> >
> > Reviewed-by: Namjae Jeon <linkinjeon@xxxxxxxxx>
> >
> > Thanks.
>
> I tend to disagree. Adding a massive amount of code that would be disabled
> can be risky. In case this code will not be in use it will not be properly
> tested and its reliability will be uncertain.
>
If you found something to be correct, please let me know that.
It would be rightly appreciated.

Best regards,
Seungwon Jeon.

> Thanks,
> Maya Erez
> Consultant for Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/