Re: [PATCH bisected regression] sched: rebuild sched domains atsuspend/resume

From: Peter Zijlstra
Date: Tue Mar 06 2012 - 16:02:41 EST


On Wed, 2012-03-07 at 00:45 +0400, Konstantin Khlebnikov wrote:
> This is fix for suspend/resume regression introduced in commit 8f2f748b0656
> ("CPU hotplug, cpusets, suspend: Don't touch cpusets during suspend/resume")
> Without this patch suspend always hangs on my thinkpad x220 (2 x CPU * HT).
>
> cpuset_update_active_cpus() not only juggles with bits in cpusets,
> it also calls sched-domains rebuilding after all.
>
> This patch restores sched-domain rebuilds, as it was before that commit.

This changelog also completely fails to explain what the problem was and
how this patch sorts it without re-introducing the problems 8f2f748b0656
was supposed to fix.

I'd rather revert the 'fix' and think about this more (its been broken
pretty much forever anyway) than tinker on top like this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/