Re: [PATCH v6] sound/soc/codecs: add LAPIS Semiconductor ML26124

[Mark Brown]

On Tue, Mar 06, 2012 at 07:49:16PM +0900, Tomoya MORINAGA wrote:
> On Tue, Mar 06, 2012ã19:00 Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>:

> > This is not what the above prototype says, the above prototype has only
> > one register in it.  You need to make this *much* clearer for the
> > registers it's affecting.

> Sorry, I couldn't understand your saying / concern.
> Do you mean I shouldn't use ml26124_update_bits() but snd_soc_update_bits() ?

Ideally you should be using the framework features.  If there is some
reason why you can't you need to make it much clearer what the reason
is so people reading the code can understand.

Attachment: signature.asc
Description: Digital signature