Re: [RFC PATCH 5/6] implement per-cpu&per-domain state machinecall_srcu()

From: Peter Zijlstra
Date: Tue Mar 06 2012 - 05:48:06 EST


On Tue, 2012-03-06 at 17:57 +0800, Lai Jiangshan wrote:
> o The srcu callback is new thing, I hope it is completely preemptible,
> even sleepable. It does in this implemetation, I use work_struct
> to stand for every srcu callback.

I didn't need the callbacks to sleep too, I just needed the read-side
srcu bit.

There's an argument against making the callbacks able to sleep like that
in that you typically want to minimize the amount of work done in the
callbacks, allowing them to sleep invites to callbacks that do _way_ too
much work.

I haven't made my mind up if I care yet.. :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/