Re: [PATCH 1/3] qla3xxx: ethernet: Fix bogus interrupt state flag.

[David Miller]

From: santosh nayak <santoshprasadnayak@xxxxxxxxx>
Date: Fri,  2 Mar 2012 20:39:05 +0530

> From: Santosh Nayak <santoshprasadnayak@xxxxxxxxx>
> 
> In 'ql_adapter_initialize'
> the first call for 'spin_unlock_irqrestore()' is with hw_flags = 0,
> which is as good as 'spin_unlock_irq()' (unconditional interrupt
> enabling). If this is intended, then for better performance
> 'spin_unlock_irqrestore()' can be replaced with 'spin_unlock_irq()'
> and 'spin_lock_irqsave()' can be replaced by 'spin_lock_irq()
> 
> Signed-off-by: Santosh Nayak <santoshprasadnayak@xxxxxxxxx>

This change is definitely correct, applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/