[PATCH] OpenRISC: Handle r0 with care

From: Richard Weinberger
Date: Mon Mar 05 2012 - 16:06:30 EST


Depending on the OpenRISC implementation a rough task may able
to change r0 and corrupt other taks.
Handle this case by setting r0 to zero on each entry point.
Also ensure that r0 is really zero before jumping into _start.

Signed-off-by: Richard Weinberger <richard@xxxxxx>

diff --git a/arch/openrisc/kernel/entry.S b/arch/openrisc/kernel/entry.S
index d5f9c35..7c9c4f6 100644
--- a/arch/openrisc/kernel/entry.S
+++ b/arch/openrisc/kernel/entry.S
@@ -130,6 +130,7 @@ handler: ;\
#define UNHANDLED_EXCEPTION(handler,vector) \
.global handler ;\
handler: ;\
+ l.andi r0,r0,0 ;\
/* r1, EPCR, ESR already saved */ ;\
l.sw PT_GPR2(r1),r2 ;\
l.sw PT_GPR3(r1),r3 ;\
@@ -185,8 +186,8 @@ handler: ;\
/* ---[ 0x100: RESET exception ]----------------------------------------- */

EXCEPTION_ENTRY(_tng_kernel_start)
+ l.andi r0,r0,0
l.jal _start
- l.andi r0,r0,0

/* ---[ 0x200: BUS exception ]------------------------------------------- */

@@ -976,6 +977,7 @@ ENTRY(_kernel_thread_helper)

.align 0x400
ENTRY(_switch)
+ l.andi r0,r0,0
/* We don't store SR as _switch only gets called in a context where
* the SR will be the same going in and coming out... */

diff --git a/arch/openrisc/kernel/head.S b/arch/openrisc/kernel/head.S
index c75018d..c439324 100644
--- a/arch/openrisc/kernel/head.S
+++ b/arch/openrisc/kernel/head.S
@@ -152,6 +152,7 @@
*/

#define EXCEPTION_HANDLE(handler) \
+ l.andi r0,r0,0 ;\
EXCEPTION_T_STORE_GPR30 ;\
l.mfspr r30,r0,SPR_ESR_BASE ;\
l.andi r30,r30,SPR_SR_SM ;\
--
1.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/