RE: [PATCH] staging: zcache: make zcache builtin only

From: Dan Magenheimer
Date: Mon Mar 05 2012 - 14:03:55 EST


> From: Seth Jennings [mailto:sjenning@xxxxxxxxxxxxxxxxxx]
> Sent: Monday, March 05, 2012 9:47 AM
> To: Greg Kroah-Hartman
> Cc: Seth Jennings; Dan Magenheimer; Thadeu Lima de Souza Cascardo; Konrad Rzeszutek Wilk; Nitin Gupta;
> Robert Jennings; devel@xxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH] staging: zcache: make zcache builtin only
>
> zcache cannot currently be loaded as a module. However
> the Kconfig allows it to be built as a module; something that
> the user probably does not intend since the module is not
> loadable.
>
> This patch switches zcache from a tristate to a bool in the Kconfig
>
> Signed-off-by: Seth Jennings <sjenning@xxxxxxxxxxxxxxxxxx>

Acked-by: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>

> ---
> drivers/staging/zcache/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig
> index 5a36fcf..3ed2c8f 100644
> --- a/drivers/staging/zcache/Kconfig
> +++ b/drivers/staging/zcache/Kconfig
> @@ -1,5 +1,5 @@
> config ZCACHE
> - tristate "Dynamic compression of swap pages and clean pagecache pages"
> + bool "Dynamic compression of swap pages and clean pagecache pages"
> # X86 dependency is because zsmalloc uses non-portable pte/tlb
> # functions
> depends on (CLEANCACHE || FRONTSWAP) && CRYPTO && X86
> --
> 1.7.5.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/