Re: [PATCH] KVM: PPC: check error return of kvmppc_core_vcpu_createfirst

[Alexander Graf]

On 02/21/2012 05:30 AM, Ben Collins wrote:
> The result of kvmppc_core_vcpu_create() was being manipulated before it was checked for IS_ERR(). Did not see the bug occur, but caught it when looking through the code.

Nice catch, but this has already been fixed by Matt:

commit c6f3830e7313eea47b526b597aadc5b18c69ad55
Author: Matt Evans <matt@xxxxxxxxxx>
Date:   Tue Dec 6 21:19:42 2011 +0000

    KVM: PPC: Fix vcpu_create dereference before validity check.

    Fix usage of vcpu struct before check that it's actually valid.

    Signed-off-by: Matt Evans <matt@xxxxxxxxxx>
    Signed-off-by: Alexander Graf <agraf@xxxxxxx>


Thanks a lot for sending the patch nevertheless!

Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/