Re: [PATCH 2/2] fat: Fix bug in enforcing Long File Name length.

[Namjae Jeon]

Hi. Andrew.

Would you plz check this patch also ?

Thanks.

2012/3/4 OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>:
> Namjae Jeon <linkinjeon@xxxxxxxxx> writes:
>
>> ÂSince '*outlen' is initialized to zero,it is currently possible to create a f ilename of length (FAT_LFN_LEN +1) when utf8 is not enabled.To enforce the FA T_LFN_LEN limit, we must perform one less iteration.
>
> Acked-by: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
>
>> Signed-off-by: Namjae Jeon <linkinjeon@xxxxxxxxx>
>> Signed-off-by: Ravishankar N <cyberax82@xxxxxxxxx>
>> ---
>> Âfs/fat/namei_vfat.c | Â Â2 +-
>> Â1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/fat/namei_vfat.c b/fs/fat/namei_vfat.c
>> index aae3b4e..98ae804 100644
>> --- a/fs/fat/namei_vfat.c
>> +++ b/fs/fat/namei_vfat.c
>> @@ -522,7 +522,7 @@ xlate_to_uni(const unsigned char *name, int len, unsigned char *outname,
>> Â Â Â Â Â Â Â op = &outname[*outlen * sizeof(wchar_t)];
>> Â Â Â } else {
>> Â Â Â Â Â Â Â for (i = 0, ip = name, op = outname, *outlen = 0;
>> - Â Â Â Â Â Â Â Â Â Â Âi < len && *outlen <= FAT_LFN_LEN;
>> + Â Â Â Â Â Â Â Â Â Â Âi < len && *outlen < FAT_LFN_LEN;
>> Â Â Â Â Â Â Â Â Â Â Â Â*outlen += 1) {
>> Â Â Â Â Â Â Â Â Â Â Â if (escape && (*ip == ':')) {
>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â if (i > len - 5)
>
> --
> OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/