Re: speakup bug

[Ted Ts'o]

On Sat, Mar 03, 2012 at 05:39:16PM +0000, Alan Cox wrote:
> On Sat, 3 Mar 2012 11:18:12 -0600
> "John G. Heim" <jheim@xxxxxxxxxxxxx> wrote:
> 
> > I need help fixing a bug in the driver for serial hardware  speech synths in 
> > the speakup screen reader. According to the comments in the code, it is in a 
> > part of the code that is trying to "steal" the serial port.
> 
> Yes - and the code is broken. To start with it's assumig a legacy PC
> serial port at 0x3F8 and that it can beat the serial layer to it.

Worse yet, it busy waits when sending characters to the UART.  Ugh...

> The proper fix is to make the drivers work via the serial layer properly.
> The speakup people have been told this repeatedly for years and years
> which is why their drivers work on less and less systems and won't run
> with things PCI or USB serial ports, and why they are forever buried in
> staging.

The driver desperately needs to be rewritten to attach to the serial
layer via a tty line discpline.  That way it will work on other types
of serial ports (i.e., PCI bus attached and USB devices).

   	  	       	       		    - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/