Re: [RFC PATCH] usb, PCI: split quirk for usb host controller tothree

[Sarah Sharp]

On Thu, Mar 01, 2012 at 09:24:35AM -0800, Greg Kroah-Hartman wrote:
> On Thu, Mar 01, 2012 at 09:17:07AM -0800, Yinghai Lu wrote:
> > so we avoid checking class again and again in that quirk.
> > 
> > need to be applied after pci/linux-next and usb/usb-next
> 
> As those are two independant trees, this needs to wait until after
> 3.4-rc1 is out.
> 
> > Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
> > 
> > ---
> >  drivers/usb/host/pci-quirks.c |   42 ++++++++++++++++++++++++++++--------------
> >  1 file changed, 28 insertions(+), 14 deletions(-)
> 
> Is this really helping anything here?  You added code overall :(

I agree with Greg.  Why change this?  Does it shave off any boot time?
Please show hard numbers for what improvements this makes.  I really
don't want to change PCI init and break people's systems.

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/