Re: [PATCH 0/3] Replace bmp085 with bmp18x

[Eric Andersson]

On 21:26 Wed 29 Feb     , Arnd Bergmann wrote:
> On Wednesday 29 February 2012, Nick Bowler wrote:
> > On 2012-02-29 20:18 +0000, Arnd Bergmann wrote:
> > > On Wednesday 29 February 2012, Eric Andersson wrote:
> > > > This patch-set replaces the BMP085 driver with a driver for Bosch Sensortec's new
> > > > generation of pressure sensors called BMP18x. These pressure sensors can be
> > > > connected on I2C but also on SPI as a variant, so the driver implements both.
> > > > Register-wise they are fully compatible with the older BMP085, so the driver will
> > > > support those chips as well.
> > > > 
> > > > The driver is based on bmp085.c by Christoph Mair.
> > > 
> > > Hmm,  the implementation looks fine, but I don't think we should add support
> > > for new devices with a one-off interface that we know is getting replaced by
> > > something generic.
> > 
> > Notwithstanding the value of using newer generic interfaces, from what I
> > can tell, there are no new sysfs attributes added by this driver over
> > the one it replaces.  If this driver is going to supersede the old one,
> > it has to retain the existing interface.  Otherwise, we must keep both
> > drivers in the tree to avoid regressions.
> 
> Well, the driver is presented as a new one ;-)
> 
> I also think it would be nicer generally speaking to do this as incremental
> updates, which could be as simple as
> 
> 1. code cleanups in bmp085 without functional changes
> 2. add support for bmp18x
> 3. rename bmp085 to bmp18x, with no other changes

Fair enough! I will create a new patch-set that is more incremental.

-- 
Best regards,
 Eric

 http://www.unixphere.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/