Re: [PATCH 5/9] writeback: introduce the pageout work

From: Fengguang Wu
Date: Thu Mar 01 2012 - 07:42:04 EST


> Please have a think about all of this and see if you can demonstrate
> how the iput() here is guaranteed safe.

There are already several __iget()/iput() calls inside fs-writeback.c.
The existing iput() calls already demonstrate its safety?

Basically the flusher works in this way

- the dirty inode list i_wb_list does not reference count the inode at all

- the flusher thread does something analog to igrab() and set I_SYNC
before going off to writeout the inode

- evice() will wait for completion of I_SYNC

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/