Re: [PATCH next] memcg: remove PCG_CACHE page_cgroup flag fix

From: Hugh Dickins
Date: Wed Feb 29 2012 - 20:21:44 EST


On Wed, 29 Feb 2012, Johannes Weiner wrote:
> On Tue, Feb 28, 2012 at 09:30:17PM -0800, Hugh Dickins wrote:
> >
> > + anon = PageAnon(page);
> > +
> > switch (ctype) {
> > case MEM_CGROUP_CHARGE_TYPE_MAPPED:
> > + anon = true;
> > + /* fallthrough */
>
> If you don't mind, could you add a small comment on why this is the
> exception where we don't trust page->mapping?

Right, I'll send an incremental fix for that.

>
> Other than that,
> Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>

Thanks,
Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/