Re: [PATCH 0/4 V2] pch_uart: Cleanups, board quirks, and user uartclkparameter

From: Darren Hart
Date: Wed Feb 29 2012 - 19:49:39 EST




On 02/29/2012 04:38 PM, Tomoya MORINAGA wrote:
> Hi
>
> Darren's patch series, I think OK.
> However, need to proceed next step.

Great, Greg are you happy with these as they are?

>
> As I said before,
> internal clock(USB_48MHz) should be used than external clock(UART_CLK)
> as default setting.
> --Reasons
> - Users don't always use 1.8432MHz as UART_CLK.
> So, In case of using except 1.8432MHz,
> the user needs to change both pch_phub and pch_uart setting (It's
> bother things).
> - High baud rate can't be used more than 115Kbps
>
> I think there is no merit to use UART_CLK.
>
> ---Merit to use 192MHz
> - Users don't have to care both pch_phub and pch_uart clock setting.
> - High baud rate can be supported

I have no objection to this provided the early serial console can work
without additional patches. So the question now is, how do we force the
192MHz clock setting BEFORE the pch_phub code runs?


--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/