Re: [PATCH 0/3] Replace bmp085 with bmp18x

From: Arnd Bergmann
Date: Wed Feb 29 2012 - 15:18:49 EST


On Wednesday 29 February 2012, Eric Andersson wrote:
> This patch-set replaces the BMP085 driver with a driver for Bosch Sensortec's new
> generation of pressure sensors called BMP18x. These pressure sensors can be
> connected on I2C but also on SPI as a variant, so the driver implements both.
> Register-wise they are fully compatible with the older BMP085, so the driver will
> support those chips as well.
>
> The driver is based on bmp085.c by Christoph Mair.

Hmm, the implementation looks fine, but I don't think we should add support
for new devices with a one-off interface that we know is getting replaced by
something generic.

Why is this not using IIO for its user interface?

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/