Re: [PATCH] get_maintainer.pl: Add support for moderated lists

From: Joe Perches
Date: Wed Feb 29 2012 - 15:16:26 EST


On Wed, 2012-02-29 at 21:06 +0100, Richard Weinberger wrote:
> Joe,
>
> Am 29.02.2012 20:58, schrieb Joe Perches:
> > <shrug> From my perspective, it's correct and simple.
> >
> > Moderated lists just means your email may get delayed
> > and you may get a "delayed due to moderation" email.
>
> Most moderated lists are "moderated" by nobody and the patch
> goes to /dev/null.
>
> > It's not a big deal to me though if Andrew wants to pick
> > this up. It seems that all current lists are marked
> > the same way. You might consider using a case insensitive
> > m/\(moderated/i though in case some list has moderated
> > in the email address itself.
>
> Let's keep the regular expressions as simple as possible.

No, let's make the expressions as specific as possible.
The expression change is trivial and wouldn't have much
effect on a 25Mhz 386.

> get_maintainer.pl is already damn slow enough.

It's pretty darn fast if you don't use --git
or --git-fallback. --git is the thing that's slow.

On my slow netbook:

$ time ./scripts/get_maintainer.pl --nogit --nogit-fallback -f drivers/net/ethernet/intel/e1000e/mac.c
Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
Bruce Allan <bruce.w.allan@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
Carolyn Wyborny <carolyn.wyborny@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
Don Skidmore <donald.c.skidmore@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
Greg Rose <gregory.v.rose@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
Alex Duyck <alexander.h.duyck@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
John Ronciak <john.ronciak@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
e1000-devel@xxxxxxxxxxxxxxxxxxxxx (open list:INTEL ETHERNET DR...)
netdev@xxxxxxxxxxxxxxx (open list:NETWORKING DRIVERS)
linux-kernel@xxxxxxxxxxxxxxx (open list)

real 0m0.716s
user 0m0.512s
sys 0m0.016s

An old desktop:
$ time ./scripts/get_maintainer.pl --nogit --nogit-fallback -f drivers/net/ethernet/intel/e1000e/mac.c
Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
Bruce Allan <bruce.w.allan@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
Carolyn Wyborny <carolyn.wyborny@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
Don Skidmore <donald.c.skidmore@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
Greg Rose <gregory.v.rose@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
Alex Duyck <alexander.h.duyck@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
John Ronciak <john.ronciak@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
e1000-devel@xxxxxxxxxxxxxxxxxxxxx (open list:INTEL ETHERNET DR...)
netdev@xxxxxxxxxxxxxxx (open list:NETWORKING DRIVERS)
linux-kernel@xxxxxxxxxxxxxxx (open list)

real 0m0.250s
user 0m0.128s
sys 0m0.024s

Using git on the desktop (linux-next)
$ time ./scripts/get_maintainer.pl -f drivers/net/ethernet/intel/e1000e/mac.c
Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx> (supporter:INTEL ETHERNET DR...,commit_signer:17/19=89%)
Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
Bruce Allan <bruce.w.allan@xxxxxxxxx> (supporter:INTEL ETHERNET DR...,commit_signer:15/19=79%)
Carolyn Wyborny <carolyn.wyborny@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
Don Skidmore <donald.c.skidmore@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
Greg Rose <gregory.v.rose@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
Alex Duyck <alexander.h.duyck@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
John Ronciak <john.ronciak@xxxxxxxxx> (supporter:INTEL ETHERNET DR...)
"David S. Miller" <davem@xxxxxxxxxxxxx> (commit_signer:2/19=11%)
Tobias Klauser <tklauser@xxxxxxxxxx> (commit_signer:1/19=5%)
Jon Mason <jdmason@xxxxxxxx> (commit_signer:1/19=5%)
e1000-devel@xxxxxxxxxxxxxxxxxxxxx (open list:INTEL ETHERNET DR...)
netdev@xxxxxxxxxxxxxxx (open list:NETWORKING DRIVERS)
linux-kernel@xxxxxxxxxxxxxxx (open list)

real 0m13.357s
user 0m9.649s
sys 0m0.388s


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/