Re: [PATCH V2 1/2] pinctrl: Introduce PINCTRL_STATE_DEFAULT, definehogs as that state

From: Linus Walleij
Date: Wed Feb 29 2012 - 11:14:13 EST


On Tue, Feb 28, 2012 at 12:55 AM, Stephen Warren <swarren@xxxxxxxxxx> wrote:

> This provides a single centralized name for the default state.
>
> Update PIN_MAP_* macros to use this state name, instead of requiring the
> user to pass a state name in.
>
> With this change, hog entries in the mapping table are defined as those
> with state name PINCTRL_STATE_DEFAULT, i.e. all entries have the same
> name. This interacts badly with the nested iteration over mapping table
> entries in pinctrl_hog_maps() and pinctrl_hog_map() which would now
> attempt to claim each hog mapping table entry multiple times. Replacing
> the custom hog code with a simple pinctrl_get()/pinctrl_enable().
>
> Update documentation and mapping tables to use this.
>
> Signed-off-by: Stephen Warren <swarren@xxxxxxxxxx>
> ---
> v2: Added all the hogging rework now described above; hopefully will solve
> U300 runtime issues.

This is a bit better, I now have my devices but I lost my hogs :-(

Trying to see if I can fix it...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/