Re: [PATCH 1/2] OpenRISC: Fix audit_syscall_exit() usage

From: Jonas Bonn
Date: Wed Feb 29 2012 - 02:46:32 EST



Thanks, Richard. There is, however, already a patch in linux-next that
provides this fix.

/Jonas

On Wed, 2012-02-29 at 01:46 +0100, Richard Weinberger wrote:
> Commit d7e7528 (Audit: push audit success and retcode into arch ptrace.h)
> changed audit_syscall_exit().
>
> Fixes:
> CC arch/openrisc/kernel/ptrace.o
> arch/openrisc/kernel/ptrace.c: In function âdo_syscall_trace_leaveâ:
> arch/openrisc/kernel/ptrace.c:206:21: error: macro "audit_syscall_exit" passed 2 arguments, but takes just 1
> arch/openrisc/kernel/ptrace.c:205:3: error: âaudit_syscall_exitâ undeclared (first use in this function)
> arch/openrisc/kernel/ptrace.c:205:3: note: each undeclared identifier is reported only once for each function it appears in
>
> Signed-off-by: Richard Weinberger <richard@xxxxxx>
> ---
> arch/openrisc/kernel/ptrace.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/arch/openrisc/kernel/ptrace.c b/arch/openrisc/kernel/ptrace.c
> index 656b94b..fa381b2 100644
> --- a/arch/openrisc/kernel/ptrace.c
> +++ b/arch/openrisc/kernel/ptrace.c
> @@ -202,8 +202,7 @@ asmlinkage void do_syscall_trace_leave(struct pt_regs *regs)
> int step;
>
> if (unlikely(current->audit_context))
> - audit_syscall_exit(AUDITSC_RESULT(regs->gpr[11]),
> - regs->gpr[11]);
> + audit_syscall_exit(regs);
>
> step = test_thread_flag(TIF_SINGLESTEP);
> if (step || test_thread_flag(TIF_SYSCALL_TRACE))


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/