Re: [PATCH 03/11] cirrus/mac89x0: print MAC via printk format specifier

[Danny Kukawka]

On Dienstag, 28. Februar 2012, Geert Uytterhoeven wrote:
> Hi David,
>
> 2012/2/28 David Miller <davem@xxxxxxxxxxxxx>:
> > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > Date: Tue, 28 Feb 2012 21:45:30 +0100
> >
> >> drivers/net/ethernet/cirrus/mac89x0.c: In function âset_mac_addressâ:
> >> drivers/net/ethernet/cirrus/mac89x0.c:597: warning: dereferencing
> >> âvoid *â pointer
> >> drivers/net/ethernet/cirrus/mac89x0.c:597: error: request for member
> >> âsa_dataâ in something not a structure or union
> >> drivers/net/ethernet/cirrus/mac89x0.c:600: warning: dereferencing
> >> âvoid *â pointer
> >> drivers/net/ethernet/cirrus/mac89x0.c:600: error: request for member
> >> âsa_dataâ in something not a structure or union
> >> drivers/net/ethernet/cirrus/mac89x0.c:595: warning: unused variable
> >> âsaddrâ
> >
> > Thanks, I've fixed this as follows and pushed to net-next:
> >
> > --------------------
> > mac89x0: Fix build error.
> >
> > Need to use the new 'saddr' variable not the void 'addr' in
> > set_mac_address().
> >
> > Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
Thanks for the fix!

> Thanks, that fixed the build.
>
> What about the is_valid_ether_addr() check?

If you mean the discussion about checking if the MAC is valid in
.ndo_set_mac_address, I'm on that issue and will hopefully send a patch soon.

Danny
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/