Re: [PATCH trivial next 9/9] gadget: Use vsprintf extention %pf withbuiltin_return_address

From: Felipe Balbi
Date: Tue Feb 28 2012 - 14:39:13 EST


On Tue, Feb 28, 2012 at 10:49:38AM -0800, Joe Perches wrote:
> Emit the function name not the address when possible.
>
> builtin_return_address() gives an address. When building
> a kernel with CONFIG_KALLSYMS, emit the actual function
> name not the address.
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>

Acked-by: Felipe Balbi <balbi@xxxxxx>

> ---
> drivers/usb/gadget/u_serial.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/gadget/u_serial.c b/drivers/usb/gadget/u_serial.c
> index 6597a68..a553bee 100644
> --- a/drivers/usb/gadget/u_serial.c
> +++ b/drivers/usb/gadget/u_serial.c
> @@ -920,7 +920,7 @@ static int gs_put_char(struct tty_struct *tty, unsigned char ch)
> unsigned long flags;
> int status;
>
> - pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %p\n",
> + pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %pf\n",
> port->port_num, tty, ch, __builtin_return_address(0));
>
> spin_lock_irqsave(&port->port_lock, flags);
> --
> 1.7.8.111.gad25c.dirty
>

--
balbi

Attachment: signature.asc
Description: Digital signature