Re: [PATCH] perf/x86: Fix HO/GO counting with SVM disabled

From: Avi Kivity
Date: Tue Feb 28 2012 - 12:24:53 EST


On 02/28/2012 05:55 PM, Joerg Roedel wrote:
>
> __init int amd_pmu_init(void)
> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
> index 5fa553b..773fee2 100644
> --- a/arch/x86/kvm/svm.c
> +++ b/arch/x86/kvm/svm.c
> @@ -29,6 +29,7 @@
> #include <linux/ftrace_event.h>
> #include <linux/slab.h>
>
> +#include <asm/perf_event.h>
> #include <asm/tlbflush.h>
> #include <asm/desc.h>
> #include <asm/kvm_para.h>
> @@ -575,6 +576,8 @@ static void svm_hardware_disable(void *garbage)
> wrmsrl(MSR_AMD64_TSC_RATIO, TSC_RATIO_DEFAULT);
>
> cpu_svm_disable();
> +
> + x86_pmu_disable_virt();
> }
>
> static int svm_hardware_enable(void *garbage)
> @@ -622,6 +625,8 @@ static int svm_hardware_enable(void *garbage)
>
> svm_init_erratum_383();
>
> + x86_pmu_enable_virt();
> +
> return 0;
> }
>

These should go into x86.c. If the functions later gain meaning on
Intel, we want them to be called (and nothing in the name suggests
they're AMD specific).

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/