Re: [PATCH] uprobes/core: handle breakpoint and signal stepexception.

[Ingo Molnar]

* Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx> wrote:

> > > The current unregistering thread waits till all other 
> > > threads that have hit a breakpoint to acquire the 
> > > uprobes_treelock before the uprobe is removed from the 
> > > rbtree.
> > 
> > s/is removed/are removed
> > 
> > ?
> > 
> 
> At a time, we are unregistering just one probe,(atleast for 
> now.) Wondering if "before uprobes are remove from rbtree." 
> sounds as if more than one uprobe is being removed at one 
> instance.

The sentence still does not parse:

  " X waits until Ys that have done Z before A is removed from
    the rbtree"

Did you want to say:

" The current unregistering thread waits till all other
  threads have hit a breakpoint, to acquire the
  uprobes_treelock before the uprobe is removed from the
  rbtree. "

(I have removed 'that' and added a comma.)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/