Re: [PATCH v2] ARM: LPC32xx: Ethernet driver

From: Roland Stigge
Date: Tue Feb 28 2012 - 08:08:41 EST


Hi,

On 2012-02-26 03:28 +100, David Miller wrote:
>> Please use a module_param() instead of a top level kernel parameter.
>
> Actually, remove this entirely, we don't add module parameters
> to force the ethernet address. That should be done in userland
> in some fashion.
>
> We've had many discussions about this recently, and this is the
> consistent policy we want to enforce in all drivers from now on.

Thanks for the note! I actually found out that in many cases, the
bootloader already initialized the hardware with the target MAC address
so we can use this one.

For the case that it _isn't_ initialized already, is it the right thing
to use a hard coded default MAC address to be replaced by the final one
in userspace? (I found such examples in some current micrel/ and amd/
drivers.)

Thanks in advance,

Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/