Re: [PATCH 1/7] time: Condense timekeeper.xtime into xtime_sec

[John Stultz]

On Tue, 2012-02-28 at 09:06 +0100, Ingo Molnar wrote:
> * John Stultz <john.stultz@xxxxxxxxxx> wrote:
> > +
> > +static void timekeeper_set_xtime(struct timekeeper *tk,
> > +					const struct timespec *ts)
> 
> Pointless (because ugly) line break.
> 
> > +{
> > +	tk->xtime_sec = ts->tv_sec;
> > +	tk->xtime_nsec = ts->tv_nsec << tk->shift;
> > +}
> > +
> > +
> > +static void timekeeper_xtime_add(struct timekeeper *tk,
> > +					const struct timespec *ts)
> 
> Pointless (because ugly) line break.

Ack on your other comments, but I'm not sure I'm following you here.
What would you rather see in this case?

(I know the 80col limit was discussed recently, but it didn't sound like
the consensus was for extending it.)

thanks
-john

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/