Re: [PATCH v2] parisc: dont unconditionally override CROSS_COMPILEfor 64 bit.

From: James Bottomley
Date: Mon Feb 27 2012 - 22:17:32 EST


On Mon, 2012-02-27 at 20:04 -0500, Mike Frysinger wrote:
> On Monday 27 February 2012 17:03:10 James Bottomley wrote:
> > --- a/arch/parisc/Makefile
> > +++ b/arch/parisc/Makefile
> >
> > -CROSS_COMPILE := hppa64-linux-gnu-
> > +
> > +# if no default set, try to find the corresponding 64 bit compiler
> > +ifeq ($(CROSS_COMPILE),)
> > +CROSS_COMPILE := $(shell $(CC) -dumpmachine | sed s/hppa-\\\(.*\\\)/hppa64-\\1-/)
> > +endif
>
> fails when using "hppa2.0-xxx". perhaps:
> CROSS_COMPILE ?= $(shell $(CC) -dumpmachine | sed 's/^hppa[^-]*-/hppa64-/')
>
> don't even need the ifeq check then

How is that different from Carlos' suggestion? The reason it doesn't
work is the same ... CROSS_COMPILE is defined to be empty.

James

èº{.nÇ+‰·Ÿ®‰­†+%ŠËlzwm…ébëæìr¸›zX§»®w¥Š{ayºÊÚë,j­¢f£¢·hš‹àz¹®w¥¢¸ ¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾«‘êçzZ+ƒùšŽŠÝj"ú!¶iO•æ¬z·švØ^¶m§ÿðà nÆàþY&—