Re: [PATCH] checkpatch: do not try to sanity test cover letters

From: Joe Perches
Date: Mon Feb 27 2012 - 19:50:13 EST


On Mon, 2012-02-27 at 19:47 -0500, Paul Gortmaker wrote:
> On Mon, Feb 27, 2012 at 7:36 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> > On Mon, 2012-02-27 at 19:29 -0500, Paul Gortmaker wrote:
> >> One possibly common workflow is this:
> >>
> >> git format-patch -o mypatches --cover-letter ^start end
> >> ./scripts/checkpatch.pl mypatches/*
> >
> > I use a script for this and don't put the check
> > in checkpatch but put the check in bash.
>
> Sure, and I can do the same. But my question to you is whether
> you think the above is a common workflow, and if the false positives
> that it generates will decrease the number of people likely to make
> using it a part of their routine?

Dunno. I generally think that tools should report
errors when the input given them is inappropriate.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/