Re: [RESUBMIT] [PATCH] Use BIOS Keyboard variable to set Numlock

[H. Peter Anvin]

> 
> Do you mind querying the state in Grub? This will mean that we'll have
> to remove the code that sets this bit from the kernel and leave it the
> in the state reported by the grub?
> 

Doing anything in Grub is idiotic at best.  The place to do it is in the
kernel BIOS stub code.

> If so I'm not sure about it. We check the BIOS data area as defined
> for IBM PCs (1981), so a fair amount of user should benefit from the
> change. Those non-BIOS boots can set the numlock=0 and won't be
> affected by this. I think this isa lot easier to implement than doing
> it in the BIOS bootstrap code.

Not really, and your patch really shows it.  It probably could be done
in less than 20 lines, total.

	-hpa



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/