Re: [PATCH 4/4] PCI: acpihp user __pci_remove_bus_device instead

From: Jesse Barnes
Date: Mon Feb 27 2012 - 15:19:39 EST


On Sat, 25 Feb 2012 13:54:23 -0800
Yinghai Lu <yinghai@xxxxxxxxxx> wrote:

> pci_stop_bus_device get called before in the same loop.
>
> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
>
> ---
> drivers/pci/hotplug/acpiphp_glue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6/drivers/pci/hotplug/acpiphp_glue.c
> ===================================================================
> --- linux-2.6.orig/drivers/pci/hotplug/acpiphp_glue.c
> +++ linux-2.6/drivers/pci/hotplug/acpiphp_glue.c
> @@ -910,7 +910,7 @@ static int disable_device(struct acpiphp
> disable_bridges(pdev->subordinate);
> pci_disable_device(pdev);
> }
> - pci_stop_and_remove_bus_device(pdev);
> + __pci_remove_bus_device(pdev);
> pci_dev_put(pdev);
> }
> }
>

Ok applied these. How about another that converts in-tree users to
pci_remove_bus_device and marks the __ version deprecated though?

--
Jesse Barnes, Intel Open Source Technology Center

Attachment: signature.asc
Description: PGP signature