RE: [PATCH 17/20] pinctrl: Add usecount to pins for muxing

From: Stephen Warren
Date: Mon Feb 27 2012 - 13:21:50 EST


Dong Aisheng wrote at Monday, February 27, 2012 12:12 AM:
> On Sun, Feb 19, 2012 at 11:45:57PM -0700, Stephen Warren wrote:
> > Multiple mapping table entries could reference the same pin, and hence
> > "own" it. This would be unusual now that pinctrl_get() represents a single
> > state for a client device, but in the future when it represents all known
> > states for a device, this is quite likely. Implement reference counting
> > for pin ownership to handle this.
> >
> > Signed-off-by: Stephen Warren <swarren@xxxxxxxxxx>
...
> > /*
> > - * If there is no kind of request function for the pin we just assume
> > - * we got it by default and proceed.
> > - */
> > + * If there is no kind of request function for the pin we just assume
> > + * we got it by default and proceed.
> > + */
>
> I remember the correct format for multiple lines of comments is:
> /*
> * ...
> */
>
> But i see the changes here are(i'm using mutt):
> /*
> * ...
> */
> Can you help explain?

It was a mistake; my editor corrupted it when I added or removed some
indentation levels. I noticed this and fixed it locally when doing
some rebasing.

> Else please also take my ACK:
> Acked-by: Dong Aisheng <dong.aisheng@xxxxxxxxxx>

Thanks.

--
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/