Re: [PATCH 2/2] x86, pci: Increase the number of iommus supported tobe MAX_IO_APICS v2

[Ingo Molnar]

* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Mon, 27 Feb 2012 08:57:41 +0100 Ingo Molnar <mingo@xxxxxxx> wrote:
> 
> > * Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > 
> > > Also we can tweak the code flow and the message to avoid dorky
> > > 80-column games:
> > 
> > > +		printk_once(KERN_ERR "intel-iommu: exceeded %d IOMMUs\n",
> > >  			  IOMMU_UNITS_SUPPORTED);
> > 
> > Not to mention the use of pr_err():
> > 
> > 		pr_err("intel-iommu: exceeded %d IOMMUs\n", IOMMU_UNITS_SUPPORTED);
> 
> Where's my pr_err_once() ;)

We suck when it comes to API consistency :-)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/