Re: RFC: memory leak in udp_table_init

From: Eric Dumazet
Date: Mon Feb 27 2012 - 00:40:23 EST


Le dimanche 26 fÃvrier 2012 Ã 14:20 -0500, David Miller a Ãcrit :
> From: Eric Dumazet <eric.dumazet@xxxxxxxxx>
> Date: Sat, 25 Feb 2012 06:19:42 +0100
>
> > [PATCH] mm: add a low limit to alloc_large_system_hash
>
> I think you should just use zero as the default minimum for all
> call sites except this UDP case we are trying to fix.
>
> For example I see you used 16 for kernel/pid.c
>
> Let's not try to do unrelated changes like that now, we can do such
> tweaks later.

It was to match the comment we have few lines above :

/*
* The pid hash table is scaled according to the amount of memory in the
* machine. From a minimum of 16 slots up to 4096 slots at one gigabyte or
* more.
*/


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/