Re: [PATCH v2] ARM: LPC32xx: Ethernet driver

[Baruch Siach]

Hi Roland,

On Sat, Feb 25, 2012 at 09:21:44PM +0100, Roland Stigge wrote:
> This patch adds an ethernet driver for the LPC32xx ARM SoC.
> 
> Signed-off-by: Roland Stigge <stigge@xxxxxxxxx>

[snip]

> +static int __init ethaddr(char *s)
> +{
> +	int i;
> +	unsigned int r[6];
> +
> +	sscanf(s, "%x:%x:%x:%x:%x:%x",
> +			&r[0], &r[1], &r[2], &r[3], &r[4], &r[5]);
> +	for (i = 0; i < 6; i++)
> +		mac_address[i] = (u8)r[i];
> +
> +	return 1;
> +}
> +__setup("ethaddr=", ethaddr);

Please use a module_param() instead of a top level kernel parameter.

You may also consider using module_param_array() here. See 
drivers/net/ethernet/freescale/fec.c for an example. Note, however, that this 
changes the format the MAC address representation. Instead of 
"01:02:03:04:05:06", use "0x01,0x02,0x03,0x04,0x05,0x06".

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@xxxxxxxxxx - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/