Re: [PATCH 2/2] staging: r8712u: Fix regression caused by commit8c213fa

From: Dan Carpenter
Date: Sat Feb 25 2012 - 13:48:41 EST


On Sat, Feb 25, 2012 at 11:17:15AM -0600, Larry Finger wrote:
> In commit 8c213fa, the command to release the firmware was placed
> in the wrong routine. With NetworkManager, problems were rare, but
> when using wicd as the network control, there is a problem as shown
> in https://bugs.archlinux.org/task/27996#comment89833.
>

This changelog is pretty rubbish.

1) The subject is rubbish.
2) Which commit was 8c213fa? Write it as 8c213fa "staging: r8712u:
Use asynchronous firmware loading". Some of us are really old and
our memory is not good anymore, so we don't know what you're talking
about if you only use the commit id.
3) A link to the bug is good, but please at least put a basic
description of the bug into the changelog itself.

regards,
dan carpenter


Attachment: signature.asc
Description: Digital signature