Re: [PATCH 3/3 v2] Staging: crystalhd: Replace the BCMLOG_ERR macrowith pr_err

[Jorgyano vieira]

On Fri, Feb 24, 2012 at 5:49 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> This is nice, but, as this is a driver, I really prefer the use of
> dev_err() instead, which allows us to properly identify the device and
> driver that spit out the error message.  Care to redo this patch in that
> style instead?
>
> thanks,
>
> greg k-h

sure, I can do this.
but first, there is something wrong about the structure dependencies
on the headers:
now, the usage of the dev_err() breaks the build.
for example:
 dev_err(&ctx->adp->pdev->dev, " ...");  on crystalhd_cmds.c returns
the error: dereferencing pointer to incomplete type.

I will fix this and send it all on another series.

-- 
Regards,
Jorgyano Vieira
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/